UI Tests for auth flows #3959

wmathurin · 2025-12-04T02:31:00Z

Adding UI tests for auth flows using the new AuthFlowTester app.

The tests expect a test_config.json file which should contain:

the login host,
test users’ usernames and passwords,
the Connected Apps, External Client Apps and Beacon Apps configuration details.

There are a number of login tests to the various Connected Apps, External Client Apps and Beacon Apps, with web server flow or user agent flow, with and without hybrid flow, with default scopes, a subset of scopes or all scopes.
There are also a number of migration tests across apps, and also on the same app with different scopes.

For information on the org test setup see the doc "13.2 Test Org Setup for Authentication Testing".

Notes
It's not ready to merge

there are no multi-user tests yet
there are no tests that involved restarting the target app (those would be useful to avoid missing bugs that involve data that did not get persisted when expected)
it's not called from CI yet.

NB: tests are actually inputing username and password in login screen (But won't work if 2FA is required)

…to auth_ui_tests # Conflicts: # native/SampleApps/AuthFlowTester/AuthFlowTester.xcodeproj/project.pbxproj

The tests expects a test_config.json with login host, consumer keys, user credentials Tests configure the login host (if needed) then do a login / request / revoke / request / logout We need the static boot config to be configured from the test also but we cannot bring the dev menu currently (no shake action possible from a UI test)

…to auth_ui_tests

…f needed

…into auth_ui_tests

- default scopes, subset or all scopes - ECA issuing JWT or not - Web server flow or user agent flow

github-actions · 2025-12-04T02:32:05Z

	1 Warning
⚠️	Big PR, try to keep changes smaller if you can.

Generated by 🚫 Danger

…ptions

wmathurin · 2025-12-04T05:54:31Z

An actual bug fix revealed by some of the tests: 8d3ab2a

github-actions · 2025-12-04T05:58:29Z

	1 Warning
⚠️	Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File	Type	Category	Description	Line	Col
SFOAuthCoordinator	Nullability	Memory error	nil assigned to a pointer which is expected to have non-null value	120	19
SFOAuthCoordinator	Nullability	Memory error	nil assigned to a pointer which is expected to have non-null value	370	15
SFOAuthCoordinator	Nullability	Memory error	nil assigned to a pointer which is expected to have non-null value	380	15
SFUserAccountManager	Nullability	Memory error	Null passed to a callee that requires a non-null 2nd parameter	1570	15
SFUserAccountManager	Nullability	Memory error	Null passed to a callee that requires a non-null 2nd parameter	1585	15
SFUserAccountManager	Nullability	Memory error	nil passed to a callee that requires a non-null 2nd parameter	2217	13
SalesforceSDKManager	Nil value used as mutex for @synchronized() (no synchronization will occur)	Logic error	Nil value used as mutex for @synchronized() (no synchronization will occur)	144	5
SalesforceSDKManager	Nil value used as mutex for @synchronized() (no synchronization will occur)	Logic error	Nil value used as mutex for @synchronized() (no synchronization will occur)	156	5

Generated by 🚫 Danger

codecov · 2025-12-04T05:58:41Z

Codecov Report

❌ Patch coverage is 54.38596% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.30%. Comparing base (a44dfc2) to head (33074eb).
⚠️ Report is 52 commits behind head on dev.

Files with missing lines	Patch %	Lines
...ore/Classes/Login/DevConfig/BootConfigEditor.swift	62.50%	15 Missing ⚠️
...SDKCore/Classes/UserAccount/SFUserAccountManager.m	11.11%	8 Missing ⚠️
...forceSDKCore/Classes/Login/SFLoginViewController.m	0.00%	2 Missing ⚠️
...forceSDKCore/Classes/Common/SalesforceSDKManager.m	0.00%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (54.38%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #3959      +/-   ##
==========================================
+ Coverage   61.68%   63.30%   +1.62%     
==========================================
  Files         255      252       -3     
  Lines       22733    22137     -596     
==========================================
- Hits        14023    14014       -9     
+ Misses       8710     8123     -587

Components	Coverage Δ
Analytics	`70.78% <ø> (ø)`
Common	`69.67% <ø> (-0.56%)`	⬇️
Core	`53.88% <55.17%> (+2.05%)`	⬆️
SmartStore	`74.59% <ø> (+0.59%)`	⬆️
MobileSync	`87.41% <ø> (ø)`

Files with missing lines	Coverage Δ
...lesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m	`42.16% <100.00%> (+0.15%)`	⬆️
...SalesforceSDKCore/Classes/OAuth/SFSDKAuthSession.m	`90.62% <100.00%> (+0.30%)`	⬆️
...forceSDKCore/Classes/Common/SalesforceSDKManager.m	`69.56% <0.00%> (ø)`
...forceSDKCore/Classes/Login/SFLoginViewController.m	`10.46% <0.00%> (ø)`
...SDKCore/Classes/UserAccount/SFUserAccountManager.m	`36.15% <11.11%> (-0.13%)`	⬇️
...ore/Classes/Login/DevConfig/BootConfigEditor.swift	`52.08% <62.50%> (+0.61%)`	⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

wmathurin · 2025-12-04T15:48:51Z

I'm thinking of having a button that dumps all the data from the AuthFlowTester screen in an alert. It would not be very useful when manually testing but would speed up the UI tests. Collecting all the static texts on the screen takes a while.
Also we might want to speed up the inputting of login options (again a single field taking a JSON would accelerate automated tests).
@brandonpage what do you think?

…edentialsView / OAuthConfigurationView and JwtTokenView Leveraging the new buttons in UI tests (to run faster)

wmathurin · 2025-12-05T00:18:17Z

I'm thinking of having a button that dumps all the data from the AuthFlowTester screen in an alert. It would not be very useful when manually testing but would speed up the UI tests. Collecting all the static texts on the screen takes a while. Also we might want to speed up the inputting of login options (again a single field taking a JSON would accelerate automated tests). @brandonpage what do you think?

Done here: 3a3c10b

wmathurin · 2025-12-05T19:46:35Z

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Common/SalesforceSDKManager.m

                    // Restart authentication with the updated configuration
                    if ([presentedViewController isKindOfClass:[SFLoginViewController class]]) {
-                        [[SFUserAccountManager sharedInstance] restartAuthenticationForViewController:(SFLoginViewController *)presentedViewController];
+                        [[SFUserAccountManager sharedInstance] restartAuthenticationForViewController:(SFLoginViewController *)presentedViewController recreateAuthRequest:YES];


Login options might change the consumer key / callback url / scopes so we need to restart the oauth request otherwise the new settings will not be used.

wmathurin · 2025-12-05T19:47:35Z

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Login/DevConfig/BootConfigEditor.swift

-                    Spacer()
-                    Image(systemName: isExpanded ? "chevron.up" : "chevron.down")
-                        .foregroundColor(.secondary)
+                Button(action: {


Adding an import button:

manual tester could paste a boot config

UI tests make use of it - it saves on a few taps and speed up the tests a bit

wmathurin · 2025-12-05T19:48:18Z

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Login/SFLoginViewController.m

                [self dismissViewControllerAnimated:YES completion:^{
-                    if ([self.delegate respondsToSelector:@selector(loginViewControllerDidReload:)]) {
-                        [self.delegate loginViewControllerDidReload:self];
+                    if ([self.delegate respondsToSelector:@selector(loginViewControllerDidChangeLoginOptions:)]) {


Reload is not enough - we need the auth request within the auth session to be recreated (see earlier comment).

wmathurin · 2025-12-05T19:48:38Z

native/SampleApps/AuthFlowTester/AuthFlowTester.xcodeproj/project.pbxproj

 		AUTH040 /* RestApiTestView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AUTH041 /* RestApiTestView.swift */; };
 		AUTH042 /* OAuthConfigurationView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AUTH043 /* OAuthConfigurationView.swift */; };
-		AUTH049 /* JwtAccessView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AUTH050 /* JwtAccessView.swift */; };
+		AUTH049 /* JwtTokenView.swift in Sources */ = {isa = PBXBuildFile; fileRef = AUTH050 /* JwtTokenView.swift */; };


Better name for the view class.

wmathurin · 2025-12-05T19:50:21Z

native/SampleApps/AuthFlowTester/AuthFlowTester/Views/JwtTokenView.swift

+import SalesforceSDKCore
+
+// MARK: - Labels Constants
+public struct JwtTokenLabels {


Pulled the labels into a struct.

they are used also when exporting details as JSON.

they are also used in UI tests.

wmathurin · 2025-12-05T19:52:30Z

native/SampleApps/AuthFlowTester/AuthFlowTester/Views/UserCredentialsView.swift

 import SalesforceSDKCore

+// MARK: - Labels Constants
+public struct CredentialsLabels {


Pulled the labels into a struct.

they are used also when exporting details as JSON.

they are also used in UI tests.

wmathurin · 2025-12-05T19:54:33Z

...mpleApps/AuthFlowTester/AuthFlowTesterUITests/PageObjects/AuthFlowTesterMainPageObject.swift

+    var clientId: String
+}
+
+class AuthFlowTesterMainPageObject {


PageObject for the AuthFlowTester main screen (and also action sheets that you can bring up from the bottom tool bar).

wmathurin · 2025-12-05T19:54:59Z

native/SampleApps/AuthFlowTester/AuthFlowTesterUITests/PageObjects/LoginPageObject.swift

+import XCTest
+import SalesforceSDKCore
+
+class LoginPageObject {


PageObject for the login screen as well as login server action sheet and login options action sheet.

wmathurin · 2025-12-05T19:55:59Z

native/SampleApps/AuthFlowTester/AuthFlowTesterUITests/test_config.json.sample

@@ -0,0 +1,87 @@
+{


A file like this one is needed for the UI tests to run.
It contain a login host, app settings and user credentials.

wmathurin · 2025-12-05T19:56:31Z

native/SampleApps/AuthFlowTester/AuthFlowTesterUITests/Tests/TestConfigUtils.swift

+// MARK: - Configuration Utility
+
+/// Utility class to parse and access test configuration from command-line arguments
+class TestConfigUtils {


Class responsible for getting configuration from test_config.json.

wmathurin · 2025-12-06T04:44:47Z

Added overview.md for the UI tests: see https://github.com/forcedotcom/SalesforceMobileSDK-iOS/blob/7580c213b3b63483d32a7fa29b26722d6f91e3f2/native/SampleApps/AuthFlowTester/AuthFlowTesterUITests/overview.md

Tests that are missing config should fail fast

The ones involving JWT-based access token were not working: - because there is server-side bug preventing the beacon app to be configured properly (switched to sdb38 org which runs more recent code where the issue has been resolved) - test code was wrongly expecting beacon consumer key instead of beacon child consumer key in the JWT

… opaque token even when sfap_api scope was granted (bug filed)

…to auth_ui_tests

… use static configuration Always setting static configuration (so that tests can assert successfully)

…n the migration or multi users tests) => to speed things up a bit and avoid being redundant Added some login tests that makes use of a dynamic configuration Updated overview.md

wmathurin · 2025-12-16T05:50:05Z

Not ready to merge yet.

However all the login tests are now passing locally.
Migration / multi users tests are still struggling though.

…sed when constructing the approval URL

Expecting more users in test_config.json Using different users in different test suites

…to auth_ui_tests

Adding rollbacks in several migration tests

github-actions · 2025-12-17T23:36:16Z

	Tests	Passed ☑️	Skipped	Failed ❌️
SalesforceSDKCore iOS ^26 Test Results	585 ran	577 ✅		8 ❌

Test	Result
SalesforceSDKCore iOS ^26 Test Results
DomainDiscoveryCoordinatorTests.testExtraQueryParameters()	❌ failure
SFUserAccountManagerTests.testAuthHandler	❌ failure
SFUserAccountManagerTests.testLoginViewControllerCustomizations	❌ failure
SalesforceRestAPITests.testCollectionUpdate	❌ failure
SalesforceRestAPITests.testCreateQuerySearchDelete	❌ failure
SalesforceRestAPITests.testUpdateWithIfUnmodifiedSince	❌ failure
SalesforceRestAPITests.testUploadOwnedFilesDelete	❌ failure
SalesforceRestAPITests.testUploadShareFileSharesSharedFilesUnshareDelete	❌ failure

View SalesforceSDKCore iOS ^26 Test Results

github-actions · 2025-12-17T23:40:23Z

	Tests	Passed ☑️	Skipped	Failed ❌️
SalesforceSDKCore iOS ^18 Test Results	586 ran	582 ✅		4 ❌

Test	Result
SalesforceSDKCore iOS ^18 Test Results
DevInfoViewControllerTests.testDevInfoViewRendersRealWorldData()	❌ failure
SFUserAccountManagerTests.testUserAccountEncoding	❌ failure
SalesforceRestAPITests.testCreateQuerySearchDelete	❌ failure
SalesforceRestAPITests.testUploadShareFileSharesSharedFilesUnshareDelete	❌ failure

View SalesforceSDKCore iOS ^18 Test Results

brandonpage

LGTM! There are an impressive amount of login scenarios covered here (and I have a lot of work to do to match).

I am a little surprised how how many SDK updates were necessary to apply the consumer key and redirect URI. Perhaps a MVVM overhaul like we did on Android could be helpful for organization in the future.

At some point I will steal your PageObject improvements and add them to the UITest repo so we can consumer them from there someday.

brandonpage · 2025-12-18T03:03:28Z

native/SampleApps/AuthFlowTester/AuthFlowTesterUITests/PageObjects/LoginPageObject.swift

+        dynamicScopes: String,
+        useWebServerFlow: Bool,
+        useHybridFlow: Bool,
+        supportWelcomeDiscovery: Bool,


I love the use of trailing commas, I didn't know that was in Swift .

Getting a 403 when invoking the single access bridge API with a beacon app access token (file a bug with auth team).

…to auth_ui_tests

wmathurin added 10 commits November 21, 2025 18:09

Beginning of UI tests for AuthFlowTester

dc69440

NB: tests are actually inputing username and password in login screen (But won't work if 2FA is required)

Merge branch 'dev' of github.com:wmathurin/SalesforceMobileSDK-iOS in…

16e6815

…to auth_ui_tests # Conflicts: # native/SampleApps/AuthFlowTester/AuthFlowTester.xcodeproj/project.pbxproj

Merge branch 'dev' of github.com:wmathurin/SalesforceMobileSDK-iOS in…

c0a4e06

…to auth_ui_tests

Basic test brings up login options and set the static configuration i…

16df64d

…f needed

Merge branch 'dev' of github.com:forcedotcom/SalesforceMobileSDK-iOS …

567e87e

…into auth_ui_tests

Login tests:

df83b95

- default scopes, subset or all scopes - ECA issuing JWT or not - Web server flow or user agent flow

Speeding up tests and checking SIDs (for hybrid flows)

516afad

Added tests involving refresh token migration

be4d829

More tests - refactored test support code also

5849109

wmathurin added 2 commits December 3, 2025 19:10

Updated test_config.json.sample

355c074

Recreating the oauthRequest for the authSession when changing login o…

8d3ab2a

…ptions

Adding import button in BootConfigEditor and export buttons in UserCr…

3a3c10b

…edentialsView / OAuthConfigurationView and JwtTokenView Leveraging the new buttons in UI tests (to run faster)

More detailled assertion failures

1689251

wmathurin commented Dec 5, 2025

View reviewed changes

wmathurin added 8 commits December 5, 2025 12:07

Additional comments

d8968e9

Fixing errors in testing code

b72a051

Added tests that use dynamic configuration also

3e32c7b

Multi user testing (WIP)

97a5241

Re-organizing login tests - removing some tests

d504ac5

Re-organized tests / prune some / added a few (multi user)

2018ae3

Overview.md for the UI tests

8cc0513

Changes to overview

7580c21

wmathurin added 16 commits December 10, 2025 14:22

Turning on coverage in scheme

5602b3b

Misc refactoring / fixes

c6f192a

Tests that are missing config should fail fast

Code coverage in SalesforceSDKCore also

478f325

Fixing switch user code in UI tests

0911cff

More readable helper test code

a1f0a01

Cleaner helper method in base class - new documentation

6ebd6de

More fixes

fa026d7

More fixes

cd376fe

More changes

b8621b3

Not hardcoding .subset definition

e98b7f6

Somehow server does not return api_instance_url for user agent flow +…

9fe5c7a

… opaque token even when sfap_api scope was granted (bug filed)

Merge branch 'dev' of github.com:wmathurin/SalesforceMobileSDK-iOS in…

b337f6d

…to auth_ui_tests

Cleaning up signatures of helper methods - nil dynamic app config <=>…

efa466a

… use static configuration Always setting static configuration (so that tests can assert successfully)

Updating overview.md for UI tests

3d160fc

Only doing validation after login in the dedicated login tests (not i…

086e197

…n the migration or multi users tests) => to speed things up a bit and avoid being redundant Added some login tests that makes use of a dynamic configuration Updated overview.md

wmathurin marked this pull request as ready for review December 16, 2025 05:49

wmathurin added 3 commits December 16, 2025 09:41

Fixing an actual SDK bug: scopes from dynamic config were NOT being u…

e6589a9

…sed when constructing the approval URL

Turning on parallelization when running tests

8b8749f

Expecting more users in test_config.json Using different users in different test suites

Merge branch 'dev' of github.com:wmathurin/SalesforceMobileSDK-iOS in…

8848eba

…to auth_ui_tests

bbirman approved these changes Dec 17, 2025

View reviewed changes

wmathurin added 2 commits December 17, 2025 15:24

Scopes were not passed through during migration

7dc8c11

During restart in some login tests

323b5e6

Adding rollbacks in several migration tests

brandonpage approved these changes Dec 18, 2025

View reviewed changes

wmathurin added 2 commits December 17, 2025 20:09

Only failures are migration from beacon app.

5d081dc

Getting a 403 when invoking the single access bridge API with a beacon app access token (file a bug with auth team).

Merge branch 'dev' of github.com:wmathurin/SalesforceMobileSDK-iOS in…

33074eb

…to auth_ui_tests

wmathurin merged commit e8a07ac into forcedotcom:dev Dec 18, 2025
21 of 27 checks passed

UI Tests for auth flows #3959

UI Tests for auth flows #3959

Uh oh!

Conversation

wmathurin commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

wmathurin commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clang Static Analysis Issues

Uh oh!

codecov bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wmathurin commented Dec 4, 2025

Uh oh!

wmathurin commented Dec 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wmathurin commented Dec 6, 2025

Uh oh!

wmathurin commented Dec 16, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandonpage left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wmathurin commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading

codecov bot commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading

github-actions bot commented Dec 17, 2025 •

edited

Loading